Repository navigation
Fix service cancellation request fields - #3
Merged
Merged
Conversation
sjmiller609
marked this pull request as ready for review
October 5, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasonCodeand optional explanatory text asreason, matching the Services API schema.CANCEL_OTHERwith detail.Testing
go test ./...go vet ./...Note
Low Risk
Scoped CLI payload fix for service cancellation with regression tests; no auth or broad behavioral changes beyond correct API field names.
Overview
Aligns
services cancelwith the Services API by mapping--reasonto JSONreasonCodeand optional--reason-detailtoreason(replacing the incorrectreason/reasonDetailfields).CLI flag names are unchanged; help text now points users at
cancellation-reasonsand notes that detail is expected forCANCEL_OTHER. AddsTestServicesCancelto assert the POST body for a predefined code and forCANCEL_OTHERwith free-text detail.Reviewed by Cursor Bugbot for commit 9704260. Bugbot is set up for automated code reviews on this repo. Configure here.